Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashdeep: fix darwin build #189235

Merged
merged 1 commit into from
Sep 2, 2022
Merged

hashdeep: fix darwin build #189235

merged 1 commit into from
Sep 2, 2022

Conversation

viraptor
Copy link
Contributor

@viraptor viraptor commented Sep 1, 2022

Description of changes

Import a patch from an existing PR to fix compilation on clang / darwin.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@viraptor
Copy link
Contributor Author

viraptor commented Sep 2, 2022

ping maintainer @karantan

@marsam marsam merged commit e445f49 into NixOS:master Sep 2, 2022
@viraptor viraptor deleted the darwin-hashdeep branch September 2, 2022 05:20
@karantan
Copy link
Contributor

karantan commented Sep 5, 2022

ping maintainer @karantan

sorry, I was away. thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants